senofy/autofirmer-expanded
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tradovate: each login's calls go to the hosts its organization is served from

Browse Source 
Lucid's users moved to their own Tradovate hosts (demo-api.lucid.ninjatrader.com,
seen 2026-11-01). The login still answers on live.tradovateapi.com, but the
shared demo socket drops a Lucid session right after its authorize (close 1006,
no status), so every Lucid firm sat at "Connecting…" on every machine. The
login answer now names the hosts (apiHosts, orgName "LucidTrading"), and the
web trader follows them.

A Tradovate client now opens its socket and makes its account, contract, fee
and report calls on the hosts its own login names; a login without apiHosts,
or with a value that isn't a plain host name, keeps demo.tradovateapi.com and
rpt-demo.tradovateapi.com. A renewal answer without apiHosts keeps the login's.
The shared contract cache still resolves with a client on the shared hosts
when there is one; a client on its organization's own only stands in. Login,
renewal and the quote feed are unchanged: Lucid's live and md hosts are the
shared ones. The debug routes follow the same hosts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Brandon Li
2026-11-01 18:12:21 -06:00
co-authored by Claude Opus 5.5
parent 10da0ca83e
commit 7fb9ddbd96
9 changed files with 151 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/clients.ts
+29 -16
View File
@@ -9,6 +9,7 @@ import { firmInstruments, isFuturesFirm, prewarmMarket } from './instruments';
import { housekeepingRoot } from './instrument-specs';
import { resolveFirmAssignments } from './account-type-resolver';
import { resolveContracts } from './contract-resolver';
import { SHARED_DEMO_HOST } from './tradovate-helpers';
import { startReporter, sendReport } from './reporter';
import { startBackupSync } from './backup-sync';
import { applyBrokerHttpDefaults, applyBrokerProxy } from './outbound-proxy';
@@ -280,27 +281,39 @@ function resolveRootsHere(): string[] {
return [...roots];
}
function triggerContractResolve(): void {
// A midnight run supersedes a pending retry; either way only one chain.
if (g.__contractResolveRetryTimer) clearTimeout(g.__contractResolveRetryTimer);
g.__contractResolveRetryTimer = undefined;
const map = ensureMap();
// Find first client with a valid access token (the Yahoo-driven resolver
// confirms contract ids against Tradovate; TopstepX clients resolve their
// own contracts but still reuse the resolver's front-month names).
// A token alone isn't enough: a client whose session died keeps its
// expired one, and resolving with that fails with nothing left to retry.
let accessToken: string | null = null;
for (const [, c] of map) {
/**
* The Tradovate token the contract resolver confirms ids with (the
* Yahoo-driven resolver checks them against Tradovate; TopstepX clients
* resolve their own contracts but still reuse the resolver's front-month
* names), and the host it belongs on.
* A token alone isn't enough: a client whose session died keeps its expired
* one, and resolving with that fails with nothing left to retry. The cache
* serves every firm, so a client on the shared hosts is preferred; one on its
* organization's own (Lucid's) only stands in.
*/
export function contractLookupToken(): { token: string; host: string } | null {
let pick: { token: string; host: string } | null = null;
for (const [, c] of ensureMap()) {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const token = (c as any).accessInfo?.accessToken;
if (!token) continue;
let authenticated = true;
try { authenticated = c.health().authenticated; } catch { /* no health: trust the token */ }
if (authenticated) { accessToken = token; break; }
if (!authenticated) continue;
const host = c instanceof TradovateClient ? c.serviceHost() : SHARED_DEMO_HOST;
if (!pick || host === SHARED_DEMO_HOST) pick = { token, host };
if (host === SHARED_DEMO_HOST) break;
}
if (!accessToken) {
return pick;
}
function triggerContractResolve(): void {
// A midnight run supersedes a pending retry; either way only one chain.
if (g.__contractResolveRetryTimer) clearTimeout(g.__contractResolveRetryTimer);
g.__contractResolveRetryTimer = undefined;
const lookup = contractLookupToken();
if (!lookup) {
const retries = (g.__contractResolveRetries ?? 0) + 1;
if (retries > CONTRACT_RESOLVE_MAX_RETRIES) {
console.log(
@@ -325,7 +338,7 @@ function triggerContractResolve(): void {
const symbols = resolveRootsHere();
g.__contractResolvedRoots = new Set(symbols);
console.log(`[contract-resolver] Resolving ${symbols.length} instruments...`);
resolveContracts(symbols, accessToken)
resolveContracts(symbols, lookup.token, lookup.host)
.then((results) => {
const rolled = Object.entries(results).filter(([, v]) => v?.alternative);
console.log(`[contract-resolver] Done — ${rolled.length} contract(s) rolled via price match`);
lib/contract-resolver.ts
+5 -2
View File
@@ -14,6 +14,7 @@
import axios from './http-client';
import { errorMessage } from './platform-client';
import { SHARED_DEMO_HOST } from './tradovate-helpers';
interface ContractInfo {
id: number;
@@ -163,11 +164,13 @@ async function findHighestVolumeContract(
* For each symbol:
* 1. Fetch {PRODUCT}=F from Yahoo to learn the exchange suffix
* 2. Probe near-month Yahoo tickers and pick the highest-volume contract
* 3. Look up the chosen name on Tradovate to get the contract ID
* 3. Look up the chosen name on Tradovate to get the contract ID — on
* `host`, the token's own (TradovateClient.serviceHost())
*/
export async function resolveContracts(
symbols: string[],
accessToken: string,
host: string = SHARED_DEMO_HOST,
): Promise<Record<string, ResolvedContract | null>> {
const headers = { Authorization: `Bearer ${accessToken}` };
const results: Record<string, ResolvedContract | null> = {};
@@ -189,7 +192,7 @@ export async function resolveContracts(
try {
const res = await axios.get(
`https://demo.tradovateapi.com/v1/contract/suggest?t=${encodeURIComponent(chosenName ?? sym)}&l=10`,
`https://${host}/v1/contract/suggest?t=${encodeURIComponent(chosenName ?? sym)}&l=10`,
{ headers }
);
const contracts: ContractInfo[] = res.data ?? [];
lib/tradovate-class.ts
+26 -11
View File
@@ -2,7 +2,7 @@
import axios from './http-client';
import type { AccountItem, AuthLoginResponse, Contract } from './tradovate-helpers';
import { computeSec, randomUUIDV4 } from './tradovate-helpers';
import { SHARED_DEMO_HOST, computeSec, demoHosts, randomUUIDV4 } from './tradovate-helpers';
import { currentTradeDateCT } from './trading-logic';
import { POINT_VALUES } from './instrument-specs';
import { getCachedContract, resolveContracts } from './contract-resolver';
@@ -516,7 +516,9 @@ export class TradovateClient {
this.lastLoginError = null;
this.consecutiveLoginFailures = 0;
this.needsLogin = false;
console.log(`${this.tag} logged in — token expires ${outcome.info.expirationTime}`);
const host = this.serviceHost();
const where = host === SHARED_DEMO_HOST ? '' : ` (${outcome.info.orgName || 'organization'} on ${host})`;
console.log(`${this.tag} logged in — token expires ${outcome.info.expirationTime}${where}`);
}
this.openSocket();
} catch (err) {
@@ -615,7 +617,7 @@ export class TradovateClient {
const randomnumber = Math.random().toString(36).substring(2, 15);
// Broker endpoint — dialled through the operator's proxy when one
// is configured (lib/outbound-proxy.ts).
const ws = brokerWebSocket(`wss://demo.tradovateapi.com/v1/websocket?r=${randomnumber}`);
const ws = brokerWebSocket(`wss://${this.serviceHost()}/v1/websocket?r=${randomnumber}`);
this.ws = ws;
this.socketOpenedAt = Date.now();
this.authorizeSent = false;
@@ -1266,7 +1268,7 @@ export class TradovateClient {
if (this.intentionalDisconnect) throw new Error('client disconnected');
try {
let reportData = (await axios.post(
'https://rpt-demo.tradovateapi.com/v1/reports/requestreport',
`https://${this.reportingHost()}/v1/reports/requestreport`,
{
name, representationType: 'json', timezone: -300,
params: [
@@ -1286,7 +1288,7 @@ export class TradovateClient {
await new Promise((r) => setTimeout(r, pTime * 1000));
if (this.intentionalDisconnect) throw new Error('client disconnected');
reportData = (await axios.get(
'https://rpt-demo.tradovateapi.com/v1/reports/getreport',
`https://${this.reportingHost()}/v1/reports/getreport`,
{ params: { 'p-ticket': pTicket }, headers: authHeaders, timeout: REPORT_TIMEOUT_MS }
)).data;
pollAttempts++;
@@ -1909,8 +1911,10 @@ export class TradovateClient {
if (!body?.accessToken) {
throw new Error(body?.errorText ? String(body.errorText) : 'renewal answered without an access token');
}
// Merge, so a renewal answer without expirationTime can't leave it undefined.
this.accessInfo = { ...this.accessInfo, ...body } as AuthLoginResponse;
// Merge, so a renewal answer without expirationTime can't leave it
// undefined — nor one without apiHosts move the session to the
// shared hosts.
this.accessInfo = { ...this.accessInfo, ...body, apiHosts: body.apiHosts ?? this.accessInfo.apiHosts } as AuthLoginResponse;
this.noteTokenExpiry();
console.log(`${this.tag} renewed access token — expires ${this.accessInfo.expirationTime}`);
} catch (err) {
@@ -1930,7 +1934,7 @@ export class TradovateClient {
return [];
}
const res = await axios.get('https://demo.tradovateapi.com/v1/account/list', {
const res = await axios.get(`https://${this.serviceHost()}/v1/account/list`, {
headers: {
Authorization: `Bearer ${this.accessInfo.accessToken}`,
},
@@ -1954,7 +1958,7 @@ export class TradovateClient {
// Under a deadline: its lookups (Yahoo, then Tradovate) must not
// hold every firm's trade. A late answer still fills the cache.
const resolved = await withDeadline(
resolveContracts([productName], this.accessInfo.accessToken),
resolveContracts([productName], this.accessInfo.accessToken, this.serviceHost()),
CONTRACT_RESOLVE_DEADLINE_MS,
'contract resolve',
);
@@ -1969,7 +1973,7 @@ export class TradovateClient {
try {
// Last resort: fall back to Tradovate's ordered suggestions.
const res = await axios.get(
`https://demo.tradovateapi.com/v1/contract/suggest?t=${encodeURIComponent(productName)}&l=20`,
`https://${this.serviceHost()}/v1/contract/suggest?t=${encodeURIComponent(productName)}&l=20`,
{ headers: { Authorization: `Bearer ${this.accessInfo.accessToken}` }, timeout: HTTP_TIMEOUT_MS }
);
const contracts: Array<{ id: number; name: string; status: string; providerTickSize: number }> = res.data ?? [];
@@ -1990,7 +1994,7 @@ export class TradovateClient {
.filter((id): id is number => id !== undefined);
const res = await axios.post(
'https://demo.tradovateapi.com/v1/contract/getproductfeeparams',
`https://${this.serviceHost()}/v1/contract/getproductfeeparams`,
{ productIds },
{ headers: { Authorization: `Bearer ${this.accessInfo.accessToken}` }, timeout: HTTP_TIMEOUT_MS }
);
@@ -2373,6 +2377,17 @@ export class TradovateClient {
return expiresAt === 0 || expiresAt > Date.now() ? info.mdAccessToken : null;
}
/** Host for this login's REST calls and trading socket — its
* organization's own when the login named one (demoHosts()). */
public serviceHost(): string {
return demoHosts(this.accessInfo?.apiHosts).service;
}
/** Host for this login's reports. */
public reportingHost(): string {
return demoHosts(this.accessInfo?.apiHosts).reporting;
}
/** Liveness snapshot for /api/health and the registry supervisor. No tokens. */
public health(): ClientHealth {
const now = Date.now();
lib/tradovate-helpers.ts
+36
View File
@@ -14,6 +14,42 @@ export interface AuthLoginResponse {
requiredNonProCertification: boolean;
outdatedSentimentPolicy: boolean;
orgName: string;
/** Where this user's organization is served — see demoHosts(). */
apiHosts?: TradovateApiHosts | null;
}
/** The hosts a login answer names, one per environment and service. */
export interface TradovateApiHosts {
live?: string;
demo?: string;
mdLive?: string;
mdDemo?: string;
reportingLive?: string;
reportingDemo?: string;
replay?: string;
}
export const SHARED_DEMO_HOST = 'demo.tradovateapi.com';
export const SHARED_DEMO_REPORTING_HOST = 'rpt-demo.tradovateapi.com';
const HOST_NAME = /^[a-z0-9-]+(\.[a-z0-9-]+)+$/i;
/**
* The hosts a login's demo-environment calls go to: REST and the trading
* socket (service), and reports. Tradovate serves some organizations from
* their own hosts and says so in the login answer's apiHosts — Lucid moved to
* demo-api.lucid.ninjatrader.com (seen 2026-11-01), and the shared demo
* socket drops a Lucid session right after its authorize. A login without
* apiHosts, or with a value that isn't a plain host name, keeps the shared
* hosts.
*/
export function demoHosts(apiHosts: TradovateApiHosts | null | undefined): { service: string; reporting: string } {
const pick = (value: unknown, fallback: string) =>
typeof value === 'string' && HOST_NAME.test(value) ? value.toLowerCase() : fallback;
return {
service: pick(apiHosts?.demo, SHARED_DEMO_HOST),
reporting: pick(apiHosts?.reportingDemo, SHARED_DEMO_REPORTING_HOST),
};
}
export interface AccountItem {