Add auto-trade scheduler with batch locking, commission gross-up, and sync gate

- Auto-trade scheduler fires every 60s; uses Promise.allSettled batch so no new trades fire while any position from the current batch is open
- Commission gross-up: read entryCommission from cash.realizedPnL after fill (fallback 2.5×contracts), grossTarget = target + 2×entryCommission
- Sync gate: TradovateClient.syncComplete flag; scheduler skips tick until every client finishes initial position/balance sync
- Contracts formula changed to Math.ceil so $1500 target = 2 contracts
- Removed all fee caching (perContractFees, recentFills, fillFee handler) from tradovate-class.ts
- Removed firm_fees table, getFirmFees, upsertFirmFee from db.ts
- Deleted instrument-configs API routes; removed Fees UI from firm settings page
- /api/instruments returns full {symbol, enabled}[] objects; dashboard filters to enabled-only for trade selector
- Added auto-trade, debug, orders, settings, and trade API routes
- Instrument selector on dashboard now driven by enabled instruments from DB

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Senofy
2026-03-09 03:31:47 -05:00
co-authored by Claude Sonnet 4.6
parent 532c2e2279
commit b2a1bdd1c3
19 changed files with 1050 additions and 218 deletions
+13
View File
@@ -0,0 +1,13 @@
import { NextResponse } from 'next/server';
import { stopScheduler, getSchedulerStatus } from '@/lib/auto-trade';
/** GET /api/auto-trade — return current scheduler status */
export async function GET() {
return NextResponse.json(getSchedulerStatus());
}
/** DELETE /api/auto-trade — stop the scheduler */
export async function DELETE() {
stopScheduler();
return NextResponse.json({ ok: true });
}
+110
View File
@@ -0,0 +1,110 @@
import { NextResponse } from 'next/server';
import { getClients, resetClients } from '@/lib/clients';
import { getFirms } from '@/lib/db';
export async function GET() {
try {
const clients = getClients();
const firms = getFirms();
const debug = firms.map((firm) => {
const client = clients.get(firm.id);
if (!client) return { firmId: firm.id, firmName: firm.name, status: 'no_client' };
return {
firmId: firm.id,
firmName: firm.name,
status: 'connected',
accountCount: client.accountList.length,
fetchDaysComplete: (client as any).fetchDaysComplete ?? 'n/a (old instance)',
lastFetchErrors: (client as any).lastFetchErrors ?? {},
lastFetchRaw: (client as any).lastFetchRaw ?? {},
accounts: client.accountList.map((acc) => ({
id: acc.id,
name: acc.name,
cash: client.accountCashBalances[acc.id] ?? null,
daysTraded: client.daysTraded[acc.id] ?? '(not set)',
dailyPnLEntries: (client.dailyPnL[acc.id] ?? []).length,
dailyPnL: client.dailyPnL[acc.id] ?? [],
})),
recentEntityEvents: client.recentEntityEvents.slice(-3).map((e) => ({
ts: new Date(e.ts).toISOString(),
entityType: e.entityType,
eventType: e.eventType,
})),
};
});
return NextResponse.json({ ok: true, ts: new Date().toISOString(), firms: debug });
} catch (err) {
console.error('[GET /api/debug]', err);
return NextResponse.json({ error: String(err) }, { status: 500 });
}
}
/** POST /api/debug — manually trigger fetchDaysTraded on all clients and return results */
export async function POST() {
try {
const clients = getClients();
const firms = getFirms();
const results = await Promise.all(
firms.map(async (firm) => {
const client = clients.get(firm.id);
if (!client || client.accountList.length === 0) {
return { firmId: firm.id, firmName: firm.name, status: 'skipped' };
}
try {
await (client as any).fetchDaysTraded();
} catch (err) {
return { firmId: firm.id, firmName: firm.name, status: 'error', error: String(err) };
}
return {
firmId: firm.id,
firmName: firm.name,
status: 'done',
fetchDaysComplete: (client as any).fetchDaysComplete ?? 'n/a',
errors: (client as any).lastFetchErrors ?? {},
rawSamples: (client as any).lastFetchRaw ?? {},
daysTraded: client.daysTraded,
dailyPnLCounts: Object.fromEntries(
Object.entries(client.dailyPnL).map(([k, v]) => [k, (v as any[]).length])
),
};
})
);
return NextResponse.json({ ok: true, ts: new Date().toISOString(), results });
} catch (err) {
console.error('[POST /api/debug]', err);
return NextResponse.json({ error: String(err) }, { status: 500 });
}
}
/**
* DELETE /api/debug — force-reinitialize all Tradovate clients with fresh instances
* Clears the global pool so getClients() recreates everything from DB on next call.
*/
export async function DELETE() {
try {
const g = global as any;
const oldCount = (g.__tradovateClients as Map<number, any> | undefined)?.size ?? 0;
// Disconnect all existing WebSocket connections before clearing
resetClients();
// Re-initialize immediately with fresh instances
getClients();
return NextResponse.json({
ok: true,
message: `Disconnected ${oldCount} old client(s) — fresh instances initializing`,
ts: new Date().toISOString(),
});
} catch (err) {
console.error('[DELETE /api/debug]', err);
return NextResponse.json({ error: String(err) }, { status: 500 });
}
}
@@ -0,0 +1,33 @@
import { NextRequest, NextResponse } from 'next/server';
import { getClients } from '@/lib/clients';
import axios from 'axios';
export async function GET(
req: NextRequest,
{ params }: { params: Promise<{ id: string }> }
) {
try {
const { id } = await params;
const firmId = parseInt(id, 10);
const clients = getClients();
const client = clients.get(firmId) as any;
if (!client) return NextResponse.json({ error: 'Client not found' }, { status: 404 });
const symbol = req.nextUrl.searchParams.get('symbol') ?? 'NQ';
const accessToken = client.accessInfo?.accessToken;
if (!accessToken) return NextResponse.json({ error: 'Not authenticated' }, { status: 401 });
const res = await axios.get(
`https://demo.tradovateapi.com/v1/contract/suggest?t=${encodeURIComponent(symbol)}&l=20`,
{ headers: { Authorization: `Bearer ${accessToken}` } }
);
return NextResponse.json({
symbol,
contracts: res.data,
recentEntityEvents: client.recentEntityEvents ?? [],
});
} catch (err: any) {
return NextResponse.json({ error: err?.message }, { status: 500 });
}
}
@@ -1,41 +0,0 @@
import { NextRequest, NextResponse } from 'next/server';
import { upsertFirmInstrumentConfig } from '@/lib/db';
export async function PUT(
req: NextRequest,
{ params }: { params: Promise<{ id: string; instrumentId: string }> }
) {
const { id: idStr, instrumentId: instrIdStr } = await params;
const firmId = parseInt(idStr, 10);
const instrumentId = parseInt(instrIdStr, 10);
if (isNaN(firmId) || isNaN(instrumentId)) {
return NextResponse.json({ error: 'Invalid id' }, { status: 400 });
}
const body = await req.json() as {
allinFee?: number;
roundtripFee?: number;
banned?: boolean;
};
if (
typeof body.allinFee !== 'number' ||
typeof body.roundtripFee !== 'number' ||
typeof body.banned !== 'boolean'
) {
return NextResponse.json({ error: 'Invalid body' }, { status: 400 });
}
try {
upsertFirmInstrumentConfig(firmId, instrumentId, {
allinFee: body.allinFee,
roundtripFee: body.roundtripFee,
banned: body.banned,
});
return NextResponse.json({ success: true });
} catch (err) {
console.error('[PUT /api/firms/:id/instrument-configs/:instrumentId]', err);
return NextResponse.json({ error: 'Failed to save config' }, { status: 500 });
}
}
@@ -1,21 +0,0 @@
import { NextRequest, NextResponse } from 'next/server';
import { getFirmFees } from '@/lib/db';
export async function GET(
_req: NextRequest,
{ params }: { params: Promise<{ id: string }> }
) {
const { id: idStr } = await params;
const firmId = parseInt(idStr, 10);
if (isNaN(firmId)) {
return NextResponse.json({ error: 'Invalid firm id' }, { status: 400 });
}
try {
return NextResponse.json(getFirmFees(firmId));
} catch (err) {
console.error('[GET /api/firms/:id/instrument-configs]', err);
return NextResponse.json({ error: 'Failed to fetch fees' }, { status: 500 });
}
}
+47
View File
@@ -0,0 +1,47 @@
import { NextRequest, NextResponse } from 'next/server';
import { getClients } from '@/lib/clients';
export async function POST(
req: NextRequest,
{ params }: { params: Promise<{ id: string }> }
) {
try {
const { id } = await params;
const firmId = parseInt(id, 10);
if (isNaN(firmId)) return NextResponse.json({ error: 'Invalid firm ID' }, { status: 400 });
const body = await req.json() as {
accountId: number;
symbol: string; // product name, e.g. "NQ"
qty: number;
action: 'Buy' | 'Sell';
orderType?: 'Market' | 'Limit';
price?: number;
};
const { accountId, symbol, qty, action, orderType = 'Market', price } = body;
if (!accountId || !symbol || !qty || !action) {
return NextResponse.json({ error: 'Missing required fields: accountId, symbol, qty, action' }, { status: 400 });
}
const clients = getClients();
const client = clients.get(firmId);
if (!client) return NextResponse.json({ error: 'Client not found for firm' }, { status: 404 });
// 1. Find the front-month contract
const contract = await client.findFrontMonthContract(symbol);
if (!contract) {
return NextResponse.json({ error: `Could not find active front-month contract for ${symbol}` }, { status: 404 });
}
console.log(`[order] front-month: ${contract.name} (id=${contract.id})`);
// 2. Place the order — resolves with the fill event (includes commission/fees)
const fill = await client.sendOrder(accountId, contract.name, qty, action, orderType, price);
console.log(`[order] fill received: price=${fill.price} qty=${fill.qty} commission=$${fill.commission} perContract=$${fill.perContractFee}`);
return NextResponse.json({ contract: { id: contract.id, name: contract.name }, fill });
} catch (err: any) {
console.error('[POST /api/firms/[id]/orders]', err);
return NextResponse.json({ error: err?.message ?? 'Order failed' }, { status: 500 });
}
}
+1 -1
View File
@@ -1,6 +1,6 @@
import { NextResponse } from 'next/server'; import { NextResponse } from 'next/server';
import { getInstruments } from '@/lib/db'; import { getInstruments } from '@/lib/db';
export function GET() { export async function GET() {
return NextResponse.json(getInstruments()); return NextResponse.json(getInstruments());
} }
+31
View File
@@ -0,0 +1,31 @@
import { NextRequest, NextResponse } from 'next/server';
import { getSetting, setSetting } from '@/lib/db';
const VALID_KEYS = ['max_concurrent_accounts'] as const;
type SettingKey = typeof VALID_KEYS[number];
export async function GET() {
const result: Record<string, string | null> = {};
for (const key of VALID_KEYS) {
result[key] = getSetting(key);
}
return NextResponse.json(result);
}
export async function PATCH(req: NextRequest) {
try {
const body = await req.json() as Partial<Record<SettingKey, string | number>>;
for (const key of VALID_KEYS) {
if (key in body) {
const raw = body[key];
if (raw === undefined || raw === null) continue;
setSetting(key, String(raw));
}
}
return NextResponse.json({ ok: true });
} catch (err: any) {
return NextResponse.json({ error: err?.message ?? 'Failed to save settings' }, { status: 500 });
}
}
+29 -2
View File
@@ -1,6 +1,14 @@
import { NextResponse } from 'next/server'; import { NextResponse } from 'next/server';
import { getFirms } from '@/lib/db'; import { getFirms } from '@/lib/db';
import { getClients } from '@/lib/clients'; import { getClients } from '@/lib/clients';
import { computeDailyTarget } from '@/lib/trading-logic';
import type { AccountConfigRow } from '@/lib/db';
function getAccountConfig(name: string, accounts: AccountConfigRow[]): AccountConfigRow | undefined {
return [...accounts]
.sort((a, b) => b.prefix.length - a.prefix.length)
.find((a) => name.startsWith(a.prefix));
}
export async function GET() { export async function GET() {
try { try {
@@ -14,18 +22,37 @@ export async function GET() {
} }
const accounts = client.accountList.map((acc) => { const accounts = client.accountList.map((acc) => {
const cash = client.accountCashBalances[acc.id] ?? { amount: 0, realizedPnL: 0 }; const cash = client.accountCashBalances[acc.id] ?? { amount: 0, realizedPnL: 0 };
const dailyPnL: { date: string; pnl: number }[] = client.dailyPnL[acc.id] ?? [];
const daysTraded: number = client.daysTraded[acc.id] ?? 0;
const totalProfit = dailyPnL.reduce((sum, d) => sum + d.pnl, 0);
// Determine if today's daily target was hit
const cfg = getAccountConfig(acc.name, f.accounts);
let targetHit = false;
if (cfg) {
const target = computeDailyTarget(cfg.profit_target, cfg.consistency, totalProfit, dailyPnL);
// Condition 1: profit target already exceeded (target=0), still need days → any activity counts
// Condition 2: target > 0 → must have made at least the computed daily target
targetHit =
// If we are just flipping take any activity as target hit
(target.amount === 0 && Math.abs(cash.realizedPnL) > 0 && client.daysTraded[acc.id] <= cfg.min_trading_days) ||
(cash.realizedPnL >= target.amount);
}
return { return {
id: acc.id, id: acc.id,
name: acc.name, name: acc.name,
active: acc.active, active: acc.active,
amount: cash.amount, amount: cash.amount,
realizedPnL: cash.realizedPnL, realizedPnL: cash.realizedPnL,
daysTraded: client.daysTraded[acc.id] ?? 0, daysTraded,
hasPosition: !!client.positions[acc.id], hasPosition: !!client.positions[acc.id],
autoLiqThreshold: client.autoLiqThresholds[acc.id] ?? 0, autoLiqThreshold: client.autoLiqThresholds[acc.id] ?? 0,
totalProfit,
targetHit,
}; };
}); });
return { firm: f.name, connected: true, accounts }; return { firm: f.name, connected: true, accounts, perContractFees: client.perContractFees };
}); });
return NextResponse.json(state); return NextResponse.json(state);
+29
View File
@@ -0,0 +1,29 @@
import { NextRequest, NextResponse } from 'next/server';
import { runTrade, startScheduler } from '@/lib/auto-trade';
import { POINT_VALUES } from '@/lib/trading-logic';
export async function POST(req: NextRequest) {
try {
const body = await req.json() as { action: 'Buy' | 'Sell'; symbol: string };
const { action, symbol } = body;
if (!action || !symbol) {
return NextResponse.json({ error: 'Missing required fields: action, symbol' }, { status: 400 });
}
if (!POINT_VALUES[symbol]) {
return NextResponse.json({ error: `Unknown symbol: ${symbol}` }, { status: 400 });
}
// Execute trade immediately for all eligible accounts
const results = await runTrade(action, symbol);
// (Re)start the 60-second scheduler with this action + symbol
startScheduler(action, symbol);
return NextResponse.json(results);
} catch (err: any) {
console.error('[POST /api/trade]', err);
return NextResponse.json({ error: err?.message ?? 'Trade failed' }, { status: 500 });
}
}
-44
View File
@@ -5,13 +5,6 @@ import { useRouter, useParams } from 'next/navigation';
const SIZE_PRESETS = [5_000, 10_000, 25_000, 50_000, 75_000, 100_000, 150_000]; const SIZE_PRESETS = [5_000, 10_000, 25_000, 50_000, 75_000, 100_000, 150_000];
interface FirmFee {
firmId: number;
symbol: string;
allinFee: number;
roundtripFee: number;
}
interface AccountConfig { interface AccountConfig {
id: number; id: number;
prefix: string; prefix: string;
@@ -89,7 +82,6 @@ export default function FirmSettingsPage() {
const [firmName, setFirmName] = useState(''); const [firmName, setFirmName] = useState('');
const [rows, setRows] = useState<RowState[]>([]); const [rows, setRows] = useState<RowState[]>([]);
const [fees, setFees] = useState<FirmFee[]>([]);
const [loadError, setLoadError] = useState(''); const [loadError, setLoadError] = useState('');
useEffect(() => { useEffect(() => {
@@ -103,11 +95,6 @@ export default function FirmSettingsPage() {
setRows(firm.accounts.map(initRow)); setRows(firm.accounts.map(initRow));
}) })
.catch(() => setLoadError('Failed to load firm')); .catch(() => setLoadError('Failed to load firm'));
fetch(`/api/firms/${id}/instrument-configs`)
.then((r) => r.json() as Promise<FirmFee[]>)
.then(setFees)
.catch(() => {});
}, [id]); }, [id]);
const updateRow = (rowId: number, patch: Partial<RowState>) => { const updateRow = (rowId: number, patch: Partial<RowState>) => {
@@ -428,37 +415,6 @@ export default function FirmSettingsPage() {
</table> </table>
</div> </div>
{/* Fees */}
<h2 className="text-sm font-semibold uppercase tracking-wider text-slate-500 mt-8 mb-3">
Fees
</h2>
<div className="bg-white border border-slate-200 rounded-xl overflow-hidden shadow-sm">
{fees.length === 0 ? (
<div className="px-4 py-8 text-center text-sm text-slate-400 italic">
No fees loaded yet
</div>
) : (
<table className="w-full text-sm border-collapse">
<thead>
<tr className="border-b border-slate-200 bg-slate-50">
<th className="px-4 py-3 text-left text-xs font-semibold uppercase tracking-wider text-slate-400">Symbol</th>
<th className="px-4 py-3 text-left text-xs font-semibold uppercase tracking-wider text-slate-400">All-In Fee</th>
<th className="px-4 py-3 text-left text-xs font-semibold uppercase tracking-wider text-slate-400">Roundtrip Fee</th>
</tr>
</thead>
<tbody>
{fees.map((fee) => (
<tr key={fee.symbol} className="border-b border-slate-100 last:border-0">
<td className="px-4 py-2.5 font-mono font-semibold text-slate-800">{fee.symbol}</td>
<td className="px-4 py-2.5 font-mono text-slate-600">${fee.allinFee.toFixed(4)}</td>
<td className="px-4 py-2.5 font-mono text-slate-600">${fee.roundtripFee.toFixed(4)}</td>
</tr>
))}
</tbody>
</table>
)}
</div>
</div> </div>
</div> </div>
); );
+194 -12
View File
@@ -5,6 +5,19 @@ import { useRouter } from 'next/navigation';
import Link from 'next/link'; import Link from 'next/link';
import type { FirmConfig, FirmState, AccountState, AccountConfig } from '@/types'; import type { FirmConfig, FirmState, AccountState, AccountConfig } from '@/types';
type SortKey = 'name' | 'balance' | 'dayPnL' | 'daysTraded' | 'target' | 'status';
type SortDir = 'asc' | 'desc';
function statusRank(account: AccountState): number {
if (isAccountDead(account)) return 0;
if (!account.active) return 1;
if (!account.hasPosition) {
if (account.targetHit) return 4; // Target Hit — most accomplished
return 2; // Flat
}
return 3; // In Trade
}
function getAccountConfig(name: string, firm: FirmConfig): AccountConfig | undefined { function getAccountConfig(name: string, firm: FirmConfig): AccountConfig | undefined {
return [...firm.accounts] return [...firm.accounts]
.sort((a, b) => b.prefix.length - a.prefix.length) .sort((a, b) => b.prefix.length - a.prefix.length)
@@ -47,6 +60,31 @@ function DetailsIcon() {
); );
} }
function SortHeader({ label, col, sortKey, sortDir, onSort }: {
label: string;
col: SortKey;
sortKey: SortKey | null;
sortDir: SortDir;
onSort: (col: SortKey) => void;
}) {
const active = sortKey === col;
return (
<th
className="px-4 py-3 text-left text-xs font-semibold uppercase tracking-wider cursor-pointer select-none transition-colors group"
onClick={() => onSort(col)}
>
<div className="flex items-center gap-1">
<span className={active ? 'text-slate-600' : 'text-slate-400 group-hover:text-slate-500'}>
{label}
</span>
<span className={`text-[10px] ${active ? 'text-slate-500' : 'text-slate-300 group-hover:text-slate-400'}`}>
{active ? (sortDir === 'asc' ? '↑' : '↓') : '↕'}
</span>
</div>
</th>
);
}
function AccountRow({ account, firm, hideDead }: { account: AccountState; firm: FirmConfig; hideDead: boolean }) { function AccountRow({ account, firm, hideDead }: { account: AccountState; firm: FirmConfig; hideDead: boolean }) {
const cfg = getAccountConfig(account.name, firm); const cfg = getAccountConfig(account.name, firm);
const dead = isAccountDead(account); const dead = isAccountDead(account);
@@ -77,10 +115,12 @@ function AccountRow({ account, firm, hideDead }: { account: AccountState; firm:
{dead {dead
? <span className="inline-block px-2.5 py-0.5 rounded-full text-xs font-semibold bg-slate-800 text-white">Dead</span> ? <span className="inline-block px-2.5 py-0.5 rounded-full text-xs font-semibold bg-slate-800 text-white">Dead</span>
: !account.active : !account.active
? <span className="inline-block px-2.5 py-0.5 rounded-full text-xs font-semibold bg-red-100 text-red-700">Inactive</span> ? <span className="inline-block px-2.5 py-0.5 rounded-full text-xs font-semibold bg-red-100 text-red-700">Hit DLL</span>
: account.hasPosition : account.hasPosition
? <span className="inline-block px-2.5 py-0.5 rounded-full text-xs font-semibold bg-blue-100 text-blue-700">In Trade</span> ? <span className="inline-block px-2.5 py-0.5 rounded-full text-xs font-semibold bg-blue-100 text-blue-700">In Trade</span>
: <span className="inline-block px-2.5 py-0.5 rounded-full text-xs font-semibold bg-slate-100 text-slate-500">Flat</span>} : account.targetHit
? <span className="inline-block px-2.5 py-0.5 rounded-full text-xs font-semibold bg-green-100 text-green-700">Target Hit</span>
: <span className="inline-block px-2.5 py-0.5 rounded-full text-xs font-semibold bg-slate-100 text-slate-500">Flat</span>}
<Link <Link
href={`/accounts/${account.id}`} href={`/accounts/${account.id}`}
className="text-slate-400 hover:text-slate-600 hover:bg-slate-200 p-1 rounded-md transition-colors inline-flex" className="text-slate-400 hover:text-slate-600 hover:bg-slate-200 p-1 rounded-md transition-colors inline-flex"
@@ -95,16 +135,35 @@ function AccountRow({ account, firm, hideDead }: { account: AccountState; firm:
); );
} }
function FirmRows({ state, firm, deleteMode, selected, onToggle, hideDead }: { function FirmRows({ state, firm, deleteMode, selected, onToggle, hideDead, sortKey, sortDir }: {
state: FirmState; state: FirmState;
firm: FirmConfig; firm: FirmConfig;
deleteMode: boolean; deleteMode: boolean;
selected: boolean; selected: boolean;
onToggle: () => void; onToggle: () => void;
hideDead: boolean; hideDead: boolean;
sortKey: SortKey | null;
sortDir: SortDir;
}) { }) {
const [open, setOpen] = useState(true); const [open, setOpen] = useState(true);
const sortedAccounts = sortKey === null ? state.accounts : [...state.accounts].sort((a, b) => {
const dir = sortDir === 'asc' ? 1 : -1;
switch (sortKey) {
case 'name': return dir * a.name.localeCompare(b.name);
case 'balance': return dir * (a.amount - b.amount);
case 'dayPnL': return dir * (a.realizedPnL - b.realizedPnL);
case 'daysTraded': return dir * (a.daysTraded - b.daysTraded);
case 'target': {
const at = getAccountConfig(a.name, firm)?.profitTarget ?? 0;
const bt = getAccountConfig(b.name, firm)?.profitTarget ?? 0;
return dir * (at - bt);
}
case 'status': return dir * (statusRank(a) - statusRank(b));
default: return 0;
}
});
return ( return (
<> <>
<tr <tr
@@ -149,7 +208,7 @@ function FirmRows({ state, firm, deleteMode, selected, onToggle, hideDead }: {
</td> </td>
</tr> </tr>
) : ( ) : (
state.accounts.map((acc) => ( sortedAccounts.map((acc) => (
<AccountRow key={acc.id} account={acc} firm={firm} hideDead={hideDead} /> <AccountRow key={acc.id} account={acc} firm={firm} hideDead={hideDead} />
)) ))
) )
@@ -158,6 +217,14 @@ function FirmRows({ state, firm, deleteMode, selected, onToggle, hideDead }: {
); );
} }
interface SchedulerStatus {
running: boolean;
action: 'Buy' | 'Sell';
symbol: string;
lastRun: string | null;
}
export default function Home() { export default function Home() {
const router = useRouter(); const router = useRouter();
const [config, setConfig] = useState<FirmConfig[]>([]); const [config, setConfig] = useState<FirmConfig[]>([]);
@@ -165,6 +232,24 @@ export default function Home() {
const [deleteMode, setDeleteMode] = useState(false); const [deleteMode, setDeleteMode] = useState(false);
const [selected, setSelected] = useState<Set<number>>(new Set()); const [selected, setSelected] = useState<Set<number>>(new Set());
const [hideDead, setHideDead] = useState(false); const [hideDead, setHideDead] = useState(false);
const [sortKey, setSortKey] = useState<SortKey | null>(null);
const [sortDir, setSortDir] = useState<SortDir>('asc');
// Trade controls
const [scheduler, setScheduler] = useState<SchedulerStatus>({ running: false, action: 'Buy', symbol: 'NQ', lastRun: null });
const [enabledSymbols, setEnabledSymbols] = useState<string[]>([]);
const [tradeSymbol, setTradeSymbol] = useState('');
const [tradeAction, setTradeAction] = useState<'Buy' | 'Sell'>('Buy');
const [tradeLoading, setTradeLoading] = useState(false);
const handleSort = (col: SortKey) => {
if (sortKey === col) {
setSortDir((d) => d === 'asc' ? 'desc' : 'asc');
} else {
setSortKey(col);
setSortDir('asc');
}
};
const fetchConfig = async () => { const fetchConfig = async () => {
try { try {
@@ -178,8 +263,25 @@ export default function Home() {
} }
}; };
const fetchScheduler = async () => {
try {
const res = await fetch('/api/auto-trade');
if (res.ok) setScheduler(await res.json());
} catch { /* ignore */ }
};
useEffect(() => { useEffect(() => {
fetch('/api/instruments')
.then((r) => r.json() as Promise<{ symbol: string; enabled: boolean }[]>)
.then((instruments) => {
const syms = instruments.filter((i) => i.enabled).map((i) => i.symbol);
setEnabledSymbols(syms);
setTradeSymbol((prev) => prev || syms[0] || 'NQ');
})
.catch(() => {});
fetchConfig(); fetchConfig();
fetchScheduler();
const fetchState = async () => { const fetchState = async () => {
try { try {
@@ -194,10 +296,30 @@ export default function Home() {
}; };
fetchState(); fetchState();
const interval = setInterval(fetchState, 5000); const stateInterval = setInterval(fetchState, 5000);
return () => clearInterval(interval); const schedulerInterval = setInterval(fetchScheduler, 5000);
return () => { clearInterval(stateInterval); clearInterval(schedulerInterval); };
}, []); }, []);
const handleStart = async () => {
setTradeLoading(true);
try {
await fetch('/api/trade', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ action: tradeAction, symbol: tradeSymbol }),
});
await fetchScheduler();
} finally {
setTradeLoading(false);
}
};
const handleStop = async () => {
await fetch('/api/auto-trade', { method: 'DELETE' });
setScheduler((s) => ({ ...s, running: false, lastRun: null }));
};
// Count dead accounts across all firms for the toggle button label // Count dead accounts across all firms for the toggle button label
const deadCount = firms.reduce((total, firmState) => { const deadCount = firms.reduce((total, firmState) => {
const firmCfg = config.find((c) => c.firm === firmState.firm); const firmCfg = config.find((c) => c.firm === firmState.firm);
@@ -285,16 +407,74 @@ export default function Home() {
)} )}
</div> </div>
</div> </div>
{/* ── Trade Controls ── */}
<div className="bg-white border border-slate-200 rounded-xl px-4 py-3 mb-4 shadow-sm flex items-center gap-3">
{scheduler.running ? (
<>
<span className="w-2 h-2 rounded-full bg-green-500 animate-pulse flex-shrink-0" />
<span className="text-sm font-semibold text-green-700">
{scheduler.symbol} · {scheduler.action}
</span>
{scheduler.lastRun && (
<span className="text-xs text-slate-400">
last run {new Date(scheduler.lastRun).toLocaleTimeString()}
</span>
)}
<button
onClick={handleStop}
className="ml-auto px-4 py-1.5 bg-red-100 hover:bg-red-200 text-red-700 text-sm font-semibold rounded-lg transition-colors"
>
Stop
</button>
</>
) : (
<>
<span className="w-2 h-2 rounded-full bg-slate-300 flex-shrink-0" />
<span className="text-sm text-slate-400 font-medium">Idle</span>
<div className="flex items-center gap-2 ml-3">
<select
value={tradeSymbol}
onChange={(e) => setTradeSymbol(e.target.value)}
className="rounded-lg border border-slate-200 bg-slate-50 px-2.5 py-1.5 text-sm font-mono text-slate-800 focus:outline-none focus:ring-2 focus:ring-blue-500"
>
{enabledSymbols.map((s) => <option key={s} value={s}>{s}</option>)}
</select>
<div className="flex rounded-lg border border-slate-200 overflow-hidden text-sm font-semibold">
<button
onClick={() => setTradeAction('Buy')}
className={`px-3 py-1.5 transition-colors ${tradeAction === 'Buy' ? 'bg-green-500 text-white' : 'text-slate-500 hover:bg-slate-50'}`}
>
Buy
</button>
<button
onClick={() => setTradeAction('Sell')}
className={`px-3 py-1.5 transition-colors border-l border-slate-200 ${tradeAction === 'Sell' ? 'bg-red-500 text-white' : 'text-slate-500 hover:bg-slate-50'}`}
>
Sell
</button>
</div>
</div>
<button
onClick={handleStart}
disabled={tradeLoading}
className="ml-auto px-4 py-1.5 bg-blue-500 hover:bg-blue-600 disabled:opacity-50 text-white text-sm font-semibold rounded-lg transition-colors"
>
{tradeLoading ? 'Starting…' : '▶ Start'}
</button>
</>
)}
</div>
<div className="w-full bg-white border border-slate-200 rounded-xl overflow-hidden shadow-sm"> <div className="w-full bg-white border border-slate-200 rounded-xl overflow-hidden shadow-sm">
<table className="w-full text-sm border-collapse"> <table className="w-full text-sm border-collapse">
<thead> <thead>
<tr className="border-b border-slate-200 bg-slate-50"> <tr className="border-b border-slate-200 bg-slate-50">
<th className="px-4 py-3 text-left text-xs font-semibold uppercase tracking-wider text-slate-400">Account</th> <SortHeader label="Account" col="name" sortKey={sortKey} sortDir={sortDir} onSort={handleSort} />
<th className="px-4 py-3 text-left text-xs font-semibold uppercase tracking-wider text-slate-400">Balance</th> <SortHeader label="Balance" col="balance" sortKey={sortKey} sortDir={sortDir} onSort={handleSort} />
<th className="px-4 py-3 text-left text-xs font-semibold uppercase tracking-wider text-slate-400">Day P&L</th> <SortHeader label="Day P&L" col="dayPnL" sortKey={sortKey} sortDir={sortDir} onSort={handleSort} />
<th className="px-4 py-3 text-left text-xs font-semibold uppercase tracking-wider text-slate-400">Days Traded</th> <SortHeader label="Days Traded" col="daysTraded" sortKey={sortKey} sortDir={sortDir} onSort={handleSort} />
<th className="px-4 py-3 text-left text-xs font-semibold uppercase tracking-wider text-slate-400">Target</th> <SortHeader label="Target" col="target" sortKey={sortKey} sortDir={sortDir} onSort={handleSort} />
<th className="px-4 py-3 text-left text-xs font-semibold uppercase tracking-wider text-slate-400">Status</th> <SortHeader label="Status" col="status" sortKey={sortKey} sortDir={sortDir} onSort={handleSort} />
</tr> </tr>
</thead> </thead>
<tbody> <tbody>
@@ -316,6 +496,8 @@ export default function Home() {
selected={selected.has(cfg.id)} selected={selected.has(cfg.id)}
onToggle={() => toggleSelected(cfg.id)} onToggle={() => toggleSelected(cfg.id)}
hideDead={hideDead} hideDead={hideDead}
sortKey={sortKey}
sortDir={sortDir}
/> />
); );
}) })
+65
View File
@@ -8,13 +8,28 @@ interface Instrument {
enabled: boolean; enabled: boolean;
} }
interface AppSettings {
max_concurrent_accounts: string | null;
}
export default function SettingsPage() { export default function SettingsPage() {
const [instruments, setInstruments] = useState<Instrument[]>([]); const [instruments, setInstruments] = useState<Instrument[]>([]);
const [maxConcurrent, setMaxConcurrent] = useState<string>('5');
const [saving, setSaving] = useState(false);
const [saved, setSaved] = useState(false);
useEffect(() => { useEffect(() => {
fetch('/api/instruments') fetch('/api/instruments')
.then((r) => r.json()) .then((r) => r.json())
.then(setInstruments); .then(setInstruments);
fetch('/api/settings')
.then((r) => r.json())
.then((s: AppSettings) => {
if (s.max_concurrent_accounts != null) {
setMaxConcurrent(s.max_concurrent_accounts);
}
});
}, []); }, []);
async function toggle(symbol: string, enabled: boolean) { async function toggle(symbol: string, enabled: boolean) {
@@ -28,6 +43,19 @@ export default function SettingsPage() {
}); });
} }
async function saveSettings() {
setSaving(true);
setSaved(false);
await fetch('/api/settings', {
method: 'PATCH',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ max_concurrent_accounts: maxConcurrent }),
});
setSaving(false);
setSaved(true);
setTimeout(() => setSaved(false), 2000);
}
return ( return (
<div className="min-h-screen bg-slate-50 p-8"> <div className="min-h-screen bg-slate-50 p-8">
<div className="max-w-7xl mx-auto"> <div className="max-w-7xl mx-auto">
@@ -42,6 +70,43 @@ export default function SettingsPage() {
<h1 className="text-2xl font-bold text-slate-900">Settings</h1> <h1 className="text-2xl font-bold text-slate-900">Settings</h1>
</div> </div>
{/* ── Trading ── */}
<h2 className="text-sm font-semibold uppercase tracking-wider text-slate-500 mb-3">
Trading
</h2>
<div className="bg-white border border-slate-200 rounded-xl shadow-sm mb-8">
<div className="flex items-center justify-between px-4 py-3">
<div>
<p className="text-sm font-medium text-slate-800">Max concurrent accounts</p>
<p className="text-xs text-slate-400 mt-0.5">
How many accounts trade in parallel per /api/trade call
</p>
</div>
<div className="flex items-center gap-3">
<input
type="number"
min={1}
max={500}
value={maxConcurrent}
onChange={(e) => setMaxConcurrent(e.target.value)}
className="w-20 rounded-lg border border-slate-200 bg-slate-50 px-3 py-1.5 text-sm text-right font-mono text-slate-800 focus:outline-none focus:ring-2 focus:ring-blue-500"
/>
<button
onClick={saveSettings}
disabled={saving}
className={`text-sm px-3 py-1.5 rounded-lg font-medium transition-colors ${
saved
? 'bg-green-500 text-white'
: 'bg-blue-500 hover:bg-blue-600 text-white disabled:opacity-50'
}`}
>
{saved ? 'Saved ✓' : saving ? 'Saving…' : 'Save'}
</button>
</div>
</div>
</div>
{/* ── Instruments ── */}
<h2 className="text-sm font-semibold uppercase tracking-wider text-slate-500 mb-3"> <h2 className="text-sm font-semibold uppercase tracking-wider text-slate-500 mb-3">
Instruments Instruments
</h2> </h2>
+271
View File
@@ -0,0 +1,271 @@
/**
* Auto-trade scheduler
*
* When a trade is triggered (POST /api/trade), the scheduler stores the
* action + symbol and fires the same trade logic every 60 seconds to pick
* up accounts that were busy (in a position) at the time of the original
* signal but have since exited and are now eligible.
*/
import { getFirms } from './db';
import { getClients } from './clients';
import { computeDailyTarget, POINT_VALUES } from './trading-logic';
import { getSetting } from './db';
import type { FirmConfig, AccountConfig } from '@/types';
import type { FirmWithAccounts } from './db';
// ── helpers ──────────────────────────────────────────────────────────────────
function isAccountDead(amount: number, autoLiqThreshold: number): boolean {
return autoLiqThreshold > 0 && amount <= autoLiqThreshold;
}
function getAccountConfig(name: string, firm: FirmConfig): AccountConfig | undefined {
return [...firm.accounts]
.sort((a, b) => b.prefix.length - a.prefix.length)
.find((a) => name.startsWith(a.prefix));
}
/** Map DB row (snake_case) → FirmConfig (camelCase) to fix field-name mismatch. */
function mapFirmConfig(firm: FirmWithAccounts): FirmConfig {
return {
id: firm.id,
firm: firm.name,
username: firm.username,
password: firm.password,
accounts: firm.accounts.map((a) => ({
prefix: a.prefix,
profitTarget: a.profit_target,
consistency: a.consistency,
minDayPnL: a.min_day_pnl,
minTradingDays: a.min_trading_days,
accountSize: a.account_size,
maxLoss: a.max_loss,
})),
};
}
// ── core trade logic ──────────────────────────────────────────────────────────
export async function runTrade(action: 'Buy' | 'Sell', symbol: string) {
const pointValue = POINT_VALUES[symbol];
if (!pointValue) throw new Error(`Unknown symbol: ${symbol}`);
const maxConcurrent = parseInt(getSetting('max_concurrent_accounts') ?? '5', 10);
const firms = getFirms();
const clients = getClients();
// ── Phase 1: collect ALL eligible accounts across ALL firms in parallel ──
type EligibleItem = {
firmName: string;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
client: any;
acc: { id: number; name: string; active: boolean };
contract: { name: string; tickSize: number };
firmConfig: FirmConfig;
cash: { amount: number; realizedPnL: number };
dailyPnL: { date: string; pnl: number }[];
daysTraded: number;
};
const allEligible: EligibleItem[] = [];
await Promise.all(firms.map(async (firm) => {
const client = clients.get(firm.id);
if (!client || client.accountList.length === 0) return;
const firmConfig = mapFirmConfig(firm);
const contract = await client.findFrontMonthContract(symbol);
if (!contract) return;
for (const acc of client.accountList) {
const cash = client.accountCashBalances[acc.id] ?? { amount: 0, realizedPnL: 0 };
const autoLiqThreshold = client.autoLiqThresholds[acc.id] ?? 0;
const dailyPnL: { date: string; pnl: number }[] = client.dailyPnL[acc.id] ?? [];
const daysTraded: number = client.daysTraded[acc.id] ?? 0;
if (isAccountDead(cash.amount, autoLiqThreshold)) continue;
if (!acc.active) continue;
if (client.positions[acc.id]) continue;
const cfg = getAccountConfig(acc.name, firmConfig);
if (!cfg) continue;
const totalProfit = dailyPnL.reduce((sum, d) => sum + d.pnl, 0);
// Only trade accounts that haven't traded yet today
if (cash.realizedPnL !== 0) continue;
// Use the same target formula as the dashboard — skip if $0 (challenge complete)
const target = computeDailyTarget(cfg.profitTarget, cfg.consistency, totalProfit, dailyPnL);
if (target.amount <= 0) continue;
allEligible.push({ firmName: firm.name, client, acc, contract, firmConfig, cash, dailyPnL, daysTraded });
}
}));
if (allEligible.length === 0) {
console.log('[auto-trade] no eligible accounts found');
return [];
}
// Take only the first batch — all fired simultaneously, no rolling pool.
// Remaining accounts wait for the next tick (which only fires once all positions are flat).
const batch = allEligible.slice(0, maxConcurrent);
console.log(`[auto-trade] ${allEligible.length} eligible account(s) — firing batch of ${batch.length}`);
// ── Phase 2: fire the batch simultaneously ──
const tradeResults = await Promise.allSettled(batch.map(async (item) => {
const { client, acc, contract, firmConfig, cash, dailyPnL, daysTraded } = item;
const cfg = getAccountConfig(acc.name, firmConfig)!;
const totalProfit = dailyPnL.reduce((sum, d) => sum + d.pnl, 0);
const target = computeDailyTarget(cfg.profitTarget, cfg.consistency, totalProfit, dailyPnL);
const contracts = Math.max(1, Math.ceil(target.amount / 1000));
const fill = await client.sendOrder(acc.id, contract.name, contracts, action, 'Market');
// Wait briefly for the cash balance WebSocket update to reflect entry commission
await new Promise(r => setTimeout(r, 1000));
const updatedCash = client.accountCashBalances[acc.id] ?? { amount: 0, realizedPnL: 0 };
// After entry, realizedPnL = -entryCommission (was 0 before), so abs = entry fee paid.
// Fall back to $2.50/contract if the WS hasn't updated yet (guarantees at least 1 extra tick).
const entryCommission = Math.abs(updatedCash.realizedPnL) || (2.5 * contracts);
const totalCommission = entryCommission * 2; // entry + exit round-trip
const grossTarget = target.amount + totalCommission;
const targetPoints = grossTarget / (pointValue * contracts);
const ticks = Math.ceil(targetPoints / contract.tickSize);
const exitPrice = action === 'Buy'
? fill.price + (ticks * contract.tickSize)
: fill.price - (ticks * contract.tickSize);
const exitAction: 'Buy' | 'Sell' = action === 'Buy' ? 'Sell' : 'Buy';
const exitOrder = await client.placeOrderNoWait(acc.id, contract.name, contracts, exitAction, 'Limit', exitPrice);
console.log(`[auto-trade] ${acc.name} (${item.firmName}) ${action} ${contracts}x${symbol} @ ${fill.price} | target $${target.amount} [${target.path}] (+$${totalCommission.toFixed(2)} comm) | exit @ ${exitPrice} (orderId=${exitOrder.orderId})`);
return {
account: acc.name,
firm: item.firmName,
status: 'filled',
contracts,
target: target.amount,
grossTarget,
totalCommission,
targetPath: target.path,
entryPrice: fill.price,
exitPrice,
commission: entryCommission,
};
}));
// Group results by firm for the response
const firmResultsMap = new Map<string, unknown[]>();
for (let i = 0; i < batch.length; i++) {
const firmName = batch[i].firmName;
if (!firmResultsMap.has(firmName)) firmResultsMap.set(firmName, []);
const r = tradeResults[i];
firmResultsMap.get(firmName)!.push(
r.status === 'fulfilled'
? r.value
: { status: 'error', reason: (r.reason as any)?.message ?? String(r.reason) }
);
}
return Array.from(firmResultsMap.entries()).map(([firm, results]) => ({ firm, results }));
}
// ── scheduler ─────────────────────────────────────────────────────────────────
interface SchedulerState {
action: 'Buy' | 'Sell';
symbol: string;
intervalId: ReturnType<typeof setInterval> | null;
lastRun: Date | null;
running: boolean;
}
// Global singleton (survives HMR in dev via module cache)
const _global = globalThis as typeof globalThis & { __autoTrader?: SchedulerState };
function getState(): SchedulerState {
if (!_global.__autoTrader) {
_global.__autoTrader = { action: 'Buy', symbol: 'NQ', intervalId: null, lastRun: null, running: false };
}
return _global.__autoTrader;
}
export function startScheduler(action: 'Buy' | 'Sell', symbol: string) {
const state = getState();
// Clear any existing interval
if (state.intervalId !== null) {
clearInterval(state.intervalId);
}
state.action = action;
state.symbol = symbol;
state.running = true;
const tick = async () => {
if (!state.running) return;
state.lastRun = new Date();
// Skip this tick until every client has completed its initial sync (positions are populated)
const clients = getClients();
const firms = getFirms();
const notReady = firms.filter(f => {
const c = clients.get(f.id);
return c && !c.syncComplete;
});
if (notReady.length > 0) {
console.log(`[scheduler] waiting for sync: ${notReady.map(f => f.name).join(', ')}`);
return;
}
// Skip this tick if any account still has an open position from the previous batch
const openPositions = firms.reduce((count, firm) => {
const client = clients.get(firm.id);
if (!client) return count;
return count + client.accountList.filter(acc => !!client.positions[acc.id]).length;
}, 0);
if (openPositions > 0) {
console.log(`[scheduler] ${openPositions} position(s) still open — skipping tick`);
return;
}
try {
const results = await runTrade(state.action, state.symbol);
const filled = results.flatMap((r: any) => r.results ?? []).filter((r: any) => r.status === 'filled').length;
if (filled > 0) console.log(`[scheduler] tick: ${filled} account(s) filled`);
} catch (err) {
console.error('[scheduler] tick error:', err);
}
};
state.intervalId = setInterval(tick, 60_000);
console.log(`[scheduler] started — ${action} ${symbol} every 60s`);
}
export function stopScheduler() {
const state = getState();
if (state.intervalId !== null) {
clearInterval(state.intervalId);
state.intervalId = null;
}
state.running = false;
console.log('[scheduler] stopped');
}
export function getSchedulerStatus() {
const state = getState();
return {
running: state.running,
action: state.action,
symbol: state.symbol,
lastRun: state.lastRun,
};
}
+16 -18
View File
@@ -1,7 +1,5 @@
import { TradovateClient } from './tradovate-class'; import { TradovateClient } from './tradovate-class';
import { getFirms, upsertFirmFee } from './db'; import { getFirms } from './db';
const SYMBOLS = ['NQ', 'MNQ', 'ES', 'MES', 'YM', 'MYM', 'RTY', 'M2K', 'GC', 'MGC', 'SI', 'CL', 'MCL', 'NG', 'ZB', 'ZN', 'ZF', '6E', '6J', '6B'];
// Use global to persist the client pool across HMR reloads in dev mode // Use global to persist the client pool across HMR reloads in dev mode
const g = global as typeof globalThis & { const g = global as typeof globalThis & {
@@ -18,31 +16,31 @@ function ensureMap(): Map<number, TradovateClient> {
export function initClient(id: number, username: string, password: string, firmName: string): TradovateClient { export function initClient(id: number, username: string, password: string, firmName: string): TradovateClient {
const map = ensureMap(); const map = ensureMap();
let feesInitialized = false; const client = new TradovateClient(username, password, () => {
const client = new TradovateClient(username, password, async () => {
console.log(`[${firmName}] sync complete — ${client.accountList.length} account(s)`); console.log(`[${firmName}] sync complete — ${client.accountList.length} account(s)`);
if (!feesInitialized) {
feesInitialized = true;
try {
const fees = await client.fetchInstrumentFees(SYMBOLS);
for (const [symbol, fee] of Object.entries(fees)) {
upsertFirmFee(id, symbol, fee, parseFloat((fee * 2).toFixed(4)));
}
const count = Object.keys(fees).length;
if (count > 0) console.log(`[${firmName}] Auto-fetched fees for ${count} symbol(s)`);
} catch (err) {
console.error(`[${firmName}] Failed to auto-fetch fees`, err);
}
}
}); });
map.set(id, client); map.set(id, client);
return client; return client;
} }
export function removeClient(id: number): void { export function removeClient(id: number): void {
const client = ensureMap().get(id);
client?.disconnect();
ensureMap().delete(id); ensureMap().delete(id);
} }
/** Disconnect all clients and clear the pool so they are recreated on next getClients() call. */
export function resetClients(): void {
const map = g.__tradovateClients;
if (map) {
for (const client of map.values()) {
try { client.disconnect(); } catch { /* ignore */ }
}
}
g.__tradovateClients = undefined;
g.__tradovateClientsInitialized = false;
}
export function getClients(): Map<number, TradovateClient> { export function getClients(): Map<number, TradovateClient> {
const map = ensureMap(); const map = ensureMap();
if (!g.__tradovateClientsInitialized) { if (!g.__tradovateClientsInitialized) {
+17 -36
View File
@@ -23,14 +23,6 @@ db.exec(`
min_trading_days INTEGER NOT NULL DEFAULT 5 min_trading_days INTEGER NOT NULL DEFAULT 5
); );
CREATE TABLE IF NOT EXISTS firm_fees (
firm_id INTEGER NOT NULL REFERENCES firms(id) ON DELETE CASCADE,
symbol TEXT NOT NULL,
allin_fee REAL NOT NULL DEFAULT 0,
roundtrip_fee REAL NOT NULL DEFAULT 0,
PRIMARY KEY (firm_id, symbol)
);
CREATE TABLE IF NOT EXISTS instruments ( CREATE TABLE IF NOT EXISTS instruments (
symbol TEXT PRIMARY KEY, symbol TEXT PRIMARY KEY,
enabled INTEGER NOT NULL DEFAULT 1 enabled INTEGER NOT NULL DEFAULT 1
@@ -98,13 +90,6 @@ export interface FirmWithAccounts extends FirmRow {
accounts: AccountConfigRow[]; accounts: AccountConfigRow[];
} }
export interface FirmFee {
firmId: number;
symbol: string;
allinFee: number;
roundtripFee: number;
}
// ── Firms ─────────────────────────────────────────────────────────────────── // ── Firms ───────────────────────────────────────────────────────────────────
export function getFirms(): FirmWithAccounts[] { export function getFirms(): FirmWithAccounts[] {
@@ -174,30 +159,26 @@ export function updateAccountConfig(id: number, data: {
return result.changes > 0; return result.changes > 0;
} }
// ── Firm Fees ──────────────────────────────────────────────────────────────── // ── Settings ────────────────────────────────────────────────────────────────
export function getFirmFees(firmId: number): FirmFee[] { db.exec(`
return (db.prepare('SELECT firm_id, symbol, allin_fee, roundtrip_fee FROM firm_fees WHERE firm_id = ? ORDER BY symbol').all(firmId) as { CREATE TABLE IF NOT EXISTS settings (
firm_id: number; key TEXT PRIMARY KEY,
symbol: string; value TEXT NOT NULL
allin_fee: number; );
roundtrip_fee: number; `);
}[]).map((r) => ({
firmId: r.firm_id, // Seed defaults if missing
symbol: r.symbol, const seedSetting = db.prepare(`INSERT OR IGNORE INTO settings (key, value) VALUES (?, ?)`);
allinFee: r.allin_fee, seedSetting.run('max_concurrent_accounts', '5');
roundtripFee: r.roundtrip_fee,
})); export function getSetting(key: string): string | null {
const row = db.prepare('SELECT value FROM settings WHERE key = ?').get(key) as { value: string } | undefined;
return row?.value ?? null;
} }
export function upsertFirmFee(firmId: number, symbol: string, allinFee: number, roundtripFee: number): void { export function setSetting(key: string, value: string): void {
db.prepare(` db.prepare(`INSERT INTO settings (key, value) VALUES (?, ?) ON CONFLICT(key) DO UPDATE SET value = excluded.value`).run(key, value);
INSERT INTO firm_fees (firm_id, symbol, allin_fee, roundtrip_fee)
VALUES (?, ?, ?, ?)
ON CONFLICT(firm_id, symbol) DO UPDATE SET
allin_fee = excluded.allin_fee,
roundtrip_fee = excluded.roundtrip_fee
`).run(firmId, symbol, allinFee, roundtripFee);
} }
// ── Instruments ────────────────────────────────────────────────────────────── // ── Instruments ──────────────────────────────────────────────────────────────
+9
View File
@@ -1,3 +1,12 @@
/** Dollar-per-point value for common futures products. */
export const POINT_VALUES: { [symbol: string]: number } = {
NQ: 20, MNQ: 2, ES: 50, MES: 5,
YM: 5, MYM: 0.5, RTY: 50, M2K: 10,
GC: 100, MGC: 10, SI: 50, CL: 1000,
MCL: 100, NG: 10000, ZB: 1000, ZN: 1000,
ZF: 1000, '6E': 125000, '6J': 12500000, '6B': 62500,
};
/** /**
* Compute the next trading day's profit target for an account. * Compute the next trading day's profit target for an account.
* *
+181 -43
View File
@@ -3,6 +3,7 @@
import axios from 'axios'; import axios from 'axios';
import type { AccountItem, AuthLoginResponse, Contract } from './tradovate-helpers'; import type { AccountItem, AuthLoginResponse, Contract } from './tradovate-helpers';
import { computeSec, randomUUIDV4 } from './tradovate-helpers'; import { computeSec, randomUUIDV4 } from './tradovate-helpers';
import { POINT_VALUES } from './trading-logic';
export class TradovateClient { export class TradovateClient {
private name: string; private name: string;
@@ -31,11 +32,30 @@ export class TradovateClient {
/** Balance floor set by the prop firm — account is blown when amount <= this value (0 = not set) */ /** Balance floor set by the prop firm — account is blown when amount <= this value (0 = not set) */
public autoLiqThresholds: { [accountId: number]: number } = {}; public autoLiqThresholds: { [accountId: number]: number } = {};
/** True once fetchDaysTraded() has finished its last full run */
public fetchDaysComplete = false;
/** Last error per account name from fetchDaysTraded() */
public lastFetchErrors: Record<string, string> = {};
/** Raw reports API response data per account (first 200 chars) for debugging */
public lastFetchRaw: Record<string, string> = {};
public products: { id: number; name: string }[] = []; public products: { id: number; name: string }[] = [];
/** Rolling buffer of the last 50 raw entity events — useful for debugging */
public recentEntityEvents: { entityType: string; eventType: string; entity: any; ts: number }[] = [];
/** True once the first requestSync has completed and positions/balances are populated. */
public syncComplete = false;
private ws: WebSocket; private ws: WebSocket;
private callbackOnSyncRequest: () => Promise<void>; private callbackOnSyncRequest: () => Promise<void>;
/** Incrementing ID for outgoing WebSocket messages — ensures concurrent orders don't clobber each other's callbacks. */
private nextMsgId = 100;
private getMsgId(): number { return this.nextMsgId++; }
// Events that we sent out, and tradovate gives us a response for the id we sent out // Events that we sent out, and tradovate gives us a response for the id we sent out
private directEventCallbacks: { private directEventCallbacks: {
[id: number]: (response: any) => void; [id: number]: (response: any) => void;
@@ -48,7 +68,6 @@ export class TradovateClient {
| 'command' | 'command'
| 'commandReport' | 'commandReport'
| 'fill' | 'fill'
| 'fillFee'
| 'executionReport' | 'executionReport'
| 'cashBalance'; | 'cashBalance';
eventType: 'Created' | 'Updated'; eventType: 'Created' | 'Updated';
@@ -151,7 +170,39 @@ export class TradovateClient {
} }
} }
// console.log('No callback found', response.d); // Buffer recent entity events (last 50)
if (response.d?.entityType) {
this.recentEntityEvents.push({ entityType: response.d.entityType, eventType: response.d.eventType, entity: response.d.entity, ts: Date.now() });
if (this.recentEntityEvents.length > 50) this.recentEntityEvents.shift();
}
// Update positions from WebSocket position events
if (response.d?.entityType === 'position' && response.d?.entity) {
const pos = response.d.entity;
if (pos.netPos !== 0) {
this.positions[pos.accountId] = {
contractId: pos.contractId,
netPos: pos.netPos,
netPrice: pos.netPrice,
timestamp: new Date(pos.timestamp),
};
} else {
delete this.positions[pos.accountId];
}
}
// Update cash balances from WebSocket cashBalance events
if (response.d?.entityType === 'cashBalance' && response.d?.entity) {
const cb = response.d.entity;
if (cb.accountId) {
this.accountCashBalances[cb.accountId] = {
amount: cb.amount,
realizedPnL: cb.realizedPnL,
};
}
}
} }
} }
} else if (event.data[0] === 'h') { } else if (event.data[0] === 'h') {
@@ -238,6 +289,7 @@ export class TradovateClient {
this.fetchDaysTraded(); this.fetchDaysTraded();
if (this.products.length > 0) { if (this.products.length > 0) {
this.syncComplete = true;
this.callbackOnSyncRequest(); this.callbackOnSyncRequest();
return; return;
} }
@@ -247,6 +299,7 @@ export class TradovateClient {
this.products = products.map((p: any) => ({ id: p.id, name: p.name })); this.products = products.map((p: any) => ({ id: p.id, name: p.name }));
console.log(`Loaded ${this.products.length} products`); console.log(`Loaded ${this.products.length} products`);
} }
this.syncComplete = true;
this.callbackOnSyncRequest(); this.callbackOnSyncRequest();
}; };
this.ws.send('product/list\n30\n\n'); this.ws.send('product/list\n30\n\n');
@@ -260,6 +313,7 @@ export class TradovateClient {
private async fetchDaysTraded(): Promise<void> { private async fetchDaysTraded(): Promise<void> {
if (!this.accessInfo?.accessToken) return; if (!this.accessInfo?.accessToken) return;
this.fetchDaysComplete = false;
const now = new Date(); const now = new Date();
const start = new Date(); const start = new Date();
@@ -273,7 +327,10 @@ export class TradovateClient {
for (const account of this.accountList) { for (const account of this.accountList) {
try { try {
const res = await axios.post( const authHeaders = { Authorization: `Bearer ${this.accessInfo.accessToken}` };
// Step 1 — request the report
let reportData = (await axios.post(
'https://rpt-demo.tradovateapi.com/v1/reports/requestreport', 'https://rpt-demo.tradovateapi.com/v1/reports/requestreport',
{ {
name: 'Fills', name: 'Fills',
@@ -287,11 +344,29 @@ export class TradovateClient {
representationType: 'json', representationType: 'json',
timezone: 0, timezone: 0,
}, },
{ headers: { Authorization: `Bearer ${this.accessInfo.accessToken}` } } { headers: authHeaders }
); )).data;
// Step 2 — if the report is queued, poll until it's ready
let pollAttempts = 0;
while (reportData?.['p-ticket'] && pollAttempts < 30) {
const pTicket: string = reportData['p-ticket'];
const pTime: number = Math.max(1, reportData['p-time'] ?? 1);
await new Promise((r) => setTimeout(r, pTime * 1000));
reportData = (await axios.get(
'https://rpt-demo.tradovateapi.com/v1/reports/getreport',
{ params: { 'p-ticket': pTicket }, headers: authHeaders }
)).data;
pollAttempts++;
}
if (!this.lastFetchRaw) this.lastFetchRaw = {};
this.lastFetchRaw[account.name] = JSON.stringify(reportData).slice(0, 500);
// _tradeDate is unquoted in the response (invalid JSON), but the "Date" field // _tradeDate is unquoted in the response (invalid JSON), but the "Date" field
// ("M/D/YY") is a valid quoted string that already reflects CME trade date. // ("M/D/YY") is a valid quoted string that already reflects CME trade date.
const raw: string = (res.data?.data ?? '[]') const rawResponse = reportData?.data ?? '[]';
const raw: string = String(rawResponse)
.replace(/"_tradeDate":\s*(\d{4}-\d{2}-\d{2})/g, '"_tradeDate": "$1"'); .replace(/"_tradeDate":\s*(\d{4}-\d{2}-\d{2})/g, '"_tradeDate": "$1"');
type Fill = { type Fill = {
_tradeDate: string; _tradeDate: string;
@@ -306,14 +381,7 @@ export class TradovateClient {
const uniqueDays = new Set(fills.map(f => f._tradeDate)); const uniqueDays = new Set(fills.map(f => f._tradeDate));
this.daysTraded[account.id] = uniqueDays.size; this.daysTraded[account.id] = uniqueDays.size;
// Dollar-per-point map for common futures products // POINT_VALUES imported from trading-logic.ts
const POINT_VALUES: { [product: string]: number } = {
NQ: 20, MNQ: 2, ES: 50, MES: 5,
YM: 5, MYM: 0.5, RTY: 50, M2K: 10,
GC: 100, MGC: 10, SI: 50, CL: 1000,
MCL: 100, NG: 10000, ZB: 1000, ZN: 1000,
ZF: 1000, '6E': 125000, '6J': 12500000, '6B': 62500,
};
// FIFO P&L computation: match buy/sell fills into round-trips // FIFO P&L computation: match buy/sell fills into round-trips
// Both the opening and closing commissions are deducted on close. // Both the opening and closing commissions are deducted on close.
@@ -364,10 +432,14 @@ export class TradovateClient {
.map(([date, pnl]) => ({ date, pnl: Math.round(pnl * 100) / 100 })) .map(([date, pnl]) => ({ date, pnl: Math.round(pnl * 100) / 100 }))
.sort((a, b) => a.date.localeCompare(b.date)); .sort((a, b) => a.date.localeCompare(b.date));
} catch (err) { } catch (err) {
console.error(`[fetchDaysTraded] ${account.name}`, err); const msg = err instanceof Error ? `${err.message}` : String(err);
console.error(`[fetchDaysTraded] ${account.name}:`, msg);
if (!this.lastFetchErrors) this.lastFetchErrors = {};
this.lastFetchErrors[account.name] = msg;
this.daysTraded[account.id] ??= 0; this.daysTraded[account.id] ??= 0;
} }
} }
this.fetchDaysComplete = true;
} }
private async login(): Promise<AuthLoginResponse> { private async login(): Promise<AuthLoginResponse> {
@@ -431,6 +503,19 @@ export class TradovateClient {
return res.data; return res.data;
} }
async findFrontMonthContract(productName: string): Promise<{ id: number; name: string; tickSize: number } | null> {
if (!this.accessInfo?.accessToken) return null;
const res = await axios.get(
`https://demo.tradovateapi.com/v1/contract/suggest?t=${encodeURIComponent(productName)}&l=20`,
{ headers: { Authorization: `Bearer ${this.accessInfo.accessToken}` } }
);
const contracts: Array<{ id: number; name: string; status: string; providerTickSize: number }> = res.data ?? [];
// Front-month = first contract whose name starts with the product symbol (results are ordered front→back)
const match = contracts.find((c) => c.name.startsWith(productName));
if (!match) return null;
return { id: match.id, name: match.name, tickSize: match.providerTickSize ?? 0.25 };
}
async fetchInstrumentFees(symbols: string[]): Promise<{ [symbol: string]: number }> { async fetchInstrumentFees(symbols: string[]): Promise<{ [symbol: string]: number }> {
if (!this.accessInfo?.accessToken || this.products.length === 0) return {}; if (!this.accessInfo?.accessToken || this.products.length === 0) return {};
@@ -494,61 +579,114 @@ export class TradovateClient {
async sendOrder( async sendOrder(
accountId: number, accountId: number,
contractId: number, contractSymbol: string, // e.g. "NQH6" — WebSocket placeorder requires "symbol"
quantity: number, quantity: number,
action: 'Buy' | 'Sell', action: 'Buy' | 'Sell',
orderType: 'Market' | 'Limit', orderType: 'Market' | 'Limit',
price?: number price?: number
): Promise<any> { ): Promise<Record<string, any>> {
if (!this.ws) { if (!this.ws) throw new Error('WebSocket not connected');
console.log('Websocket not connected');
return;
}
this.ws.send( this.ws.send(
`user/registeraudituseraction\n25\n\n${JSON.stringify({ `user/registeraudituseraction\n25\n\n${JSON.stringify({
accountId: accountId, accountId,
actionType: action + orderType, actionType: action + orderType,
details: `DOM MESZ5: Buy ${orderType}, Buy ${quantity} ${orderType}${ details: `${action} ${quantity} ${contractSymbol} ${orderType}${price ? ` @ ${price}` : ''}, TIF Day`,
price ? ` ${price}` : ''
}, TIF Day`,
})}` })}`
); );
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
this.directEventCallbacks[26] = (response: any) => { const msgId = this.getMsgId();
// console.log('Order id', response?.orderId); this.directEventCallbacks[msgId] = (response: any) => {
console.log('Order placed, order id: ', response); console.log(`[sendOrder] raw ack:`, JSON.stringify(response));
if (typeof response === 'string' || !response) {
reject(new Error(typeof response === 'string' ? response : 'Empty response from order/placeorder'));
return;
}
// Tradovate returns the command object: { id, commandStatus, orderId, ... }
const orderId = response.orderId ?? response.id;
console.log(`[sendOrder] orderId=${orderId} status=${response.commandStatus}`);
// TODO: Implement for limit orders and rejected market orders // Wait for the fill event — it carries the real execution price
const timeout = setTimeout(() => {
// If we don't get a response within 5 seconds, reject the promise reject(new Error(`Order ${orderId} acknowledged but no fill within 30s (market may be closed)`));
setTimeout(() => { }, 30000);
reject(new Error('No response from order placement'));
}, 5000);
this.indirectEventCallbacks.push({ this.indirectEventCallbacks.push({
entityType: 'fill', entityType: 'fill',
eventType: 'Created', eventType: 'Created',
validator: (item: any) => item?.orderId === response?.orderId, validator: (item: any) => item?.orderId === orderId,
callback: (response: any) => { callback: (fill: any) => {
resolve(response); clearTimeout(timeout);
console.log(`[sendOrder] fill:`, JSON.stringify(fill));
resolve(fill);
}, },
}); });
}; };
this.ws.send( this.ws.send(
`order/placeorder\n26\n\n${JSON.stringify({ `order/placeorder\n${msgId}\n\n${JSON.stringify({
accountId: accountId, accountId,
action: action, action,
symbol: contractId, symbol: contractSymbol,
orderQty: quantity, orderQty: quantity,
orderType: orderType, orderType,
price: price, price,
timeInForce: 'Day', timeInForce: 'Day',
text: 'DOM', text: 'DOM',
})}` })}`
); );
}); });
} }
/** Place an order and resolve as soon as the command is acknowledged (does not wait for fill). */
async placeOrderNoWait(
accountId: number,
contractSymbol: string,
quantity: number,
action: 'Buy' | 'Sell',
orderType: 'Market' | 'Limit',
price?: number
): Promise<{ orderId?: number }> {
if (!this.ws) throw new Error('WebSocket not connected');
const msgId = this.getMsgId();
return new Promise((resolve, reject) => {
this.directEventCallbacks[msgId] = (response: any) => {
if (typeof response === 'string') {
reject(new Error(response));
return;
}
resolve({ orderId: response?.orderId ?? response?.id });
};
this.ws.send(
`order/placeorder\n${msgId}\n\n${JSON.stringify({
accountId,
action,
symbol: contractSymbol,
orderQty: quantity,
orderType,
price,
timeInForce: 'Day',
text: 'DOM',
})}`
);
});
}
/** Close the WebSocket connection and stop all intervals. Call before discarding the instance. */
public disconnect(): void {
try { this.ws?.close(); } catch { /* ignore */ }
}
/** Register a one-time callback for when a fill arrives for a given orderId. */
onFill(orderId: number, callback: (fill: any) => void): void {
this.indirectEventCallbacks.push({
entityType: 'fill',
eventType: 'Created',
validator: (item: any) => item?.orderId === orderId,
callback,
});
}
} }
+4
View File
@@ -26,6 +26,10 @@ export interface AccountState {
hasPosition: boolean; hasPosition: boolean;
/** Balance floor from Tradovate's auto-liquidation profile (0 = not set) */ /** Balance floor from Tradovate's auto-liquidation profile (0 = not set) */
autoLiqThreshold: number; autoLiqThreshold: number;
/** Sum of all historical daily P&L entries */
totalProfit: number;
/** True when today's realizedPnL has met or exceeded the computed daily target */
targetHit: boolean;
} }
export interface FirmState { export interface FirmState {