Fix seven type errors that broke next build
`npm run build` failed on a clean checkout, so nothing on master could be built for production. `npm run dev` does not hard-fail on type errors, which is why it went unnoticed. - state route returned client.perContractFees, which has never existed on TradovateClient on any branch; nothing consumed it - mapFirmConfig omitted bannedSymbols. Type gap only: the trade path calls isSymbolBanned() against the DB directly, so bans were always enforced - initClient's sync callback was sync where the constructor wants () => Promise<void> - accessInfo and ws are assigned during async connect/auth, never in the constructor, so they take definite-assignment assertions - the socket payload's inline entityType union had drifted five members behind the indirect-callback union above it, making the 'position' and 'cashBalance' branches unreachable to the compiler. Both now share a TradovateEntityType alias. Type-only: those handlers ran fine at runtime Behaviour is unchanged throughout. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
3cc7ddcc5c
commit
fc08a41c4b
+1
-1
@@ -19,7 +19,7 @@ function ensureMap(): Map<number, TradovateClient> {
|
||||
|
||||
export function initClient(id: number, username: string, password: string, firmName: string): TradovateClient {
|
||||
const map = ensureMap();
|
||||
const client = new TradovateClient(username, password, () => {
|
||||
const client = new TradovateClient(username, password, async () => {
|
||||
console.log(`[${firmName}] sync complete — ${client.accountList.length} account(s)`);
|
||||
});
|
||||
map.set(id, client);
|
||||
|
||||
Reference in New Issue
Block a user